Skip to content

Fix ReverseWords class and test #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

JackZeled0n
Copy link

@JackZeled0n JackZeled0n commented Jan 3, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@JackZeled0n
Copy link
Author

JackZeled0n commented Jan 3, 2021

@ayaankhan98 why when I make a PR always load the last commit but not the mine?

@ayaankhan98
Copy link
Member

@ayaankhan98 why when I make a PR always load the last commit but not the mine?

i didn't get what you are trying to say. will you please try to elaborate your point?

@JackZeled0n
Copy link
Author

@ayaankhan98 why when I make a PR always load the last commit but not the mine?

i didn't get what you are trying to say. will you please try to elaborate your point?

In the details from checks I can see the log and when it run the Junit5 test on ubuntu it seems that take the last version of the branch but not with my changes

@yanglbme yanglbme merged commit bd60e13 into TheAlgorithms:Development Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants