Skip to content

add permutation #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2022
Merged

add permutation #2932

merged 3 commits into from
Feb 9, 2022

Conversation

cpiao3
Copy link
Contributor

@cpiao3 cpiao3 commented Jan 31, 2022

Describe your change:

  • [ x] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • [ x] I have read CONTRIBUTING.md.
  • [ x] This pull request is all my own work -- I have not plagiarized.
  • [ x] I know that pull requests will not be merged if they fail the automated tests.
  • [ x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new Java files are placed inside an existing directory.
  • [ x] All filenames are in all uppercase characters with no spaces or dashes.
  • [ x] All functions and variable names follow Java naming conventions.
  • [ x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cpiao3
Copy link
Contributor Author

cpiao3 commented Feb 3, 2022

@siriak can you review this; added combination as well.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpiao3
Copy link
Contributor Author

cpiao3 commented Feb 6, 2022

@siriak added tests and deleted main()

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 12c67bc into TheAlgorithms:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants