Skip to content

Add Test case for EggDropping #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

Add Test case for EggDropping #3687

merged 1 commit into from
Oct 27, 2022

Conversation

naanagon
Copy link
Contributor

@naanagon naanagon commented Oct 26, 2022 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@naanagon
Copy link
Contributor Author

@siriak , @yanglbme Test cases passed. Can you please take a look..?

@naanagon
Copy link
Contributor Author

@siriak , @yanglbme - could you please review, build is green now.

@naanagon naanagon changed the title Added Test cases for egg droppings Add Test case for egg droppings Oct 27, 2022
@naanagon naanagon changed the title Add Test case for egg droppings Add Test case for EggDropping Oct 27, 2022
@naanagon naanagon requested a review from yanglbme October 27, 2022 16:43
siriak
siriak approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit b2393d6 into TheAlgorithms:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naanagon @yanglbme @siriak