added scheduling algorithm #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yanglbme Please review. Thanks |
yanglbme
requested changes
Oct 27, 2018
| import java.util.ArrayList; | ||
| import java.util.Comparator; | ||
| import java.util.*; | ||
|
|
There was a problem hiding this comment.
Hello, please add some descriptions about what the algorithm does. Thx
Others/SJF.java
Outdated
| remainingProcess = new ArrayList<Process>(); | ||
|
|
||
| gantChart = new ArrayList<Integer>(); | ||
| arrivals = new HashMap<Integer, ArrayList<Process>>(); |
There was a problem hiding this comment.
We use Java 8, so you can simplify your code. Like this👇
gantChart = new ArrayList<>();
arrivals = new HashMap<>();
|
@yanglbme made changes as mentioned by you. please review thanks |
yanglbme
requested changes
Oct 27, 2018
There was a problem hiding this comment.
Use Java doc comments, please. See the following example:
/**
* Shortest job first.
*
* <p>Shortest job first (SJF) or shortest job next,
* is a scheduling policy that selects the waiting process
* with the smallest execution time to execute next..........
*
* @author shivg7706
* @since 2018/10/27
*/
|
@yanglbme Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling Algorithm - Priority and Shortest job first which solves the starvation