Issue compiling error in SinglyLinkedList.java fixed #668
+3,657
−1,949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed bug in method gcd(int, int)
Add method for minimum number of coins required for given amount
Removing the Travis CI badge as it points to a dead URL. As this repository has [very few tests](https://github.com/TheAlgorithms/Java/search?q=Test&unscoped_q=Test), maybe a CI build might be a bit too much.
Remove Tracis CI badge from README.md
Bring fileName into correspondence with className which is marked as public
className is error
source coding is a little complex
Added MatrixFastPower.java
…rules commit divideconquer\ClosesPair.java Refactorized ClosestPair.java. Finding nearest cartesian points. Refactorized ClosestPair.java. Finding nearest cartesian points.
Refactorized ClosestPair.java in order to be compliant with java sun rules
fixed spelling mistakes
Added and explanation to SkylineProblem.
Method prime(num) uses only odd numbers from 3 to square root of num as divisors. In method functioning(y) we iterate over odd numbers as all even numbers (except of 2) are not prime. In method functioning(y) we check at first if the number is palindrome and then if it's prime, so we don't have to call the heavy prime() method for every number. The speed of searching palindromic primes is significantly increased.
Update PalindromicPrime.java
Added Euler's totient Function
- Fix wrong assignation
Include condition to check if the queue is full when inserting values into the queue
Update PriorityQueues.java
Addition of CRC
#708 (bugfix for fibonacci sequence function)
I made the code shorter and less prone to mistakes by removing the "size" variable altogether from the LinkedList class. I found that after each push/pop operation, changing the value of size did make the code more efficient, but made it more prone to mistakes. So, for empty stack, a simple "head == null" was enough, which has been incorporated.
Updated StackOfLinkedList.java
- The "count" variable made the code more prone to errors, so I removed and replaced it with another "getSize()" function. - The value of "next" was initialized to null. - Major improvements of code were given to "insertNth()" and "deleteHead()" functions for efficiency. - A new function "deleteNth()" was defined, increasing the usefulness of the program.
Major Updates in SinglyLinkedList.java
|
@Goku1999 Please don't raise a PR for merging development into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
33 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem in compiling this particular problem is because we are calling default constructor when it is not even present in the Node class