Skip to content

Add test case to Fibonacci Search Algorithm #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

Ankush263
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • [✅ ] Add Test Case?

Checklist:

  • [✅ ] I have read CONTRIBUTING.md.
  • [✅ ] This pull request is all my own work -- I have not plagiarized.
  • [✅ ] I know that pull requests will not be merged if they fail the automated tests.
  • [ ✅ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [✅ ] All new JavaScript files are placed inside an existing directory.
  • [✅ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [✅ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ✅ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose all searches should use a unified test suite, but that can be implemented later.

@raklaptudirm raklaptudirm added the tests Adds or fixes tests; issue that points out bugs in the tests label Jun 11, 2022
@raklaptudirm raklaptudirm merged commit f5be6b2 into TheAlgorithms:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Adds or fixes tests; issue that points out bugs in the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants