Skip to content

feat: add MergeTwoSortedLinkedLIsts algorithms #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

ahnge
Copy link
Contributor

@ahnge ahnge commented Oct 5, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ahnge ahnge changed the title feat: add mergeTwoSortedLinkedLIsts algorithms feat: add MergeTwoSortedLinkedLIsts algorithms Oct 5, 2023
@ahnge
Copy link
Contributor Author

ahnge commented Oct 5, 2023

I'm participating in hacktoberfest.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is unnecessary, this should be just the merge function.

(Note also that really, this "sorted merge" approach is more flexible: The proper abstraction is that of an iterator. This could then be an iterator merge taking two iterators and producing a merged one, which could be used to merge arrays, linked lists, doubly linked lists, whatever is iterable inorder and can be created inorder.)

ahnge and others added 2 commits October 10, 2023 09:08
change the function params and return value from Node to LinkedList.
@ahnge ahnge requested a review from appgurueu October 10, 2023 05:02
@raklaptudirm raklaptudirm merged commit ca761d8 into TheAlgorithms:master Oct 11, 2023
@ahnge
Copy link
Contributor Author

ahnge commented Oct 11, 2023

Could you please label this pr as hacktoberfest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants