Skip to content

Added Queue Data Structure #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2017
Merged

Added Queue Data Structure #15

merged 2 commits into from
Oct 18, 2017

Conversation

LumaLivy
Copy link
Contributor

I tried to follow the style of the Stack implementation closely to reduce confusion. Tested and works well enough. Submitted as part of #14!

@dynamitechetan
Copy link
Member

@r0hit-gupta please review.

r0hit-gupta
r0hit-gupta requested changes Sep 29, 2017
View reviewed changes
Copy link
Member

@r0hit-gupta r0hit-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job buddy. I would just suggest you to implement the same using an Array instead of an Object. This would remove unnecessary functions from the code and would run much faster.

@ms10398
Copy link
Member

ms10398 commented Oct 5, 2017

Please follow along as @r0hit-gupta said and replace the object with array.
Thank you

@ms10398 ms10398 merged commit 0129ca4 into TheAlgorithms:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0hit-gupta r0hit-gupta r0hit-gupta requested changes

Assignees

@r0hit-gupta r0hit-gupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LumaLivy @dynamitechetan @ms10398 @r0hit-gupta