Skip to content

Create UpdateDirectory.js #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2020

Conversation

sahilbansal17
Copy link
Contributor

@sahilbansal17 sahilbansal17 commented May 10, 2020

Welcome to Javascript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Fixes an enhancement issue

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Javascript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
Copy link
Member

cclauss commented May 10, 2020

Awesome! Would it make sense to rename index.js --> UpdateDirectory.js to be more self-documenting and also leave us room to create other automation scripts?

I like that the output highlights the two different implementations of heap sort (#164) although I do not quite understand why JavaScript and Python disagree on the sort order of file names. ;-).

@cclauss cclauss changed the title Fixes: #160 Create UpdateDirectory.js May 10, 2020
@cclauss cclauss merged commit 3730807 into TheAlgorithms:master May 10, 2020
@cclauss
Copy link
Member

cclauss commented May 13, 2020

@sahilbansal17 We have a problem with this script in that the sort can not figure out which should come first HeapSort.js or Heapsort.js so it creates alternating updates on each commit to a pull request. In the first, s comes first. In the second, S comes first...

Is there a way to modify the script's sort so that capital S always comes before s?

@sahilbansal17
Copy link
Contributor Author

Sure, I will try to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants