run: node .github/workflows/UpdateDirectory.js #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sahilbansal17 Your review please... Your script seems to be doing its magic just fine! |
cclauss
changed the title
poyea
approved these changes
May 12, 2020
|
@poyea Thanks for your review. The heap sort thing is covered in #164 where I am advocating that we have a benchmark that determines which implementation lives and which one dies. It is bugging me that we have a directory called algorithm because every submission to this repo should be an algorithm. We should move the files in that directory to other dirs that provide more specificity to what kind of algorithm it is. QuickSelect.js --> Search make sense to me. Linear-Algebra-Javascript should probably be renamed to Linear-Algebra. |
sahilbansal17
approved these changes
May 12, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to JavaScript community
Fixes #160