Skip to content

Improved BubbleSort and added doctests to it #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improved BubbleSort and added doctests to it #442

wants to merge 5 commits into from

Conversation

marsonya
Copy link
Contributor

@marsonya marsonya commented Oct 9, 2020

Welcome to JavaScript community

Describe your change:

Here are the changes I made in the Sorts/BubbleSort.js file:

  • Added Wikipedia Link.
  • Improved Comments and Formatting.
  • The first BubbleSort (using 2 for loops) was not returning the array. Changed that.
  • Improved the Implementation Examples and Console logs.
  • And Finally, added doctests as mentioned in (Issue #142)
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@marsonya marsonya closed this Oct 9, 2020
@TheAlgorithms TheAlgorithms deleted a comment from nurulc Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant