Skip to content

Improved CocktailShakerSort and added Doctests #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Improved CocktailShakerSort and added Doctests #465

wants to merge 12 commits into from

Conversation

marsonya
Copy link
Contributor

Here are the changes I made in the Sorts/CocktailShakerSort.js file:

  • Improved Comments and Formatting.
  • The function in CocktailShakerSort was not returning the array. Changed that.
  • Improved the Implementation Examples and Console logs.
  • And Finally, added doctests as mentioned in (Issue #142)
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

@marsonya marsonya closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm will be requested when the pull request is marked ready for review raklaptudirm is a code owner

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu will be requested when the pull request is marked ready for review appgurueu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marsonya