-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Algorithm to print a month's calendar. #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a dynamic programming algorithm to print out a Month's calendar.
#14 Contribution. Added a new algorithm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split the one liner conditionals into different lines. In isLeapYear
else is not required, you can just use return false
Removed the else but breaking the conditional raises standard js formatting issues. |
Split block of conditionals in separate lines to improve readability
@raklaptudirm from next time please open separate PRs for different tasks (you had squashed Kadane's algorithm improvement and the calendar together) |
@ruppysuppy Actually, I ran |
This pull request adds an algorithm to
Dynamic-programming
which accepts a month in the format m/y, and prints the month's calendar.Commits before 0f703a5 are unrelated and have been reverted back in 7c3b0ad.
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.