Skip to content

Fixes: #586 - fix failing tests #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kirans08
Copy link

@kirans08 kirans08 commented May 9, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@kirans08
Copy link
Author

kirans08 commented May 9, 2021

This is a partial fix for #586 - There is one more TODO in https://github.com/TheAlgorithms/Javascript/blob/master/.github/workflows/nodejs.yml

Changes

  • Fixes the unit tests - Linear-Algebra/test/test.js and String/LevenshteinDistance.test.js
  • Update the workflow to run the fixed tests

image

@kirans08 kirans08 changed the title Fixes: #586 Fixes: #586 - correct failing tests May 9, 2021
@kirans08 kirans08 changed the title Fixes: #586 - correct failing tests Fixes: #586 - fix failing tests May 9, 2021
@raklaptudirm
Copy link
Member

These tests have been fixed at #609 . Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants