Skip to content

feat: Strings Palindrome #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

v1ktoryy
Copy link

related to: #14

@ParthS007
Copy link
Member

This pull request introduces 4 alerts when merging 816351c into 2d50357 - view on LGTM.com

new alerts:

  • 4 for Missing variable declaration

Comment posted by LGTM.com

@v1ktoryy v1ktoryy force-pushed the feat/StringsPalindrome branch from 816351c to 78ab564 Compare October 20, 2018 12:46
@ParthS007
Copy link
Member

This pull request introduces 4 alerts when merging 78ab564 into 2d50357 - view on LGTM.com

new alerts:

  • 4 for Missing variable declaration

Comment posted by LGTM.com

@v1ktoryy v1ktoryy force-pushed the feat/StringsPalindrome branch from 78ab564 to 062ca1f Compare October 20, 2018 12:54
@ParthS007
Copy link
Member

This pull request introduces 1 alert when merging 062ca1f into 2d50357 - view on LGTM.com

new alerts:

  • 1 for Assignment to constant

Comment posted by LGTM.com

@@ -0,0 +1,29 @@

var isPalindrome = function (text){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to use ES6 standards

Copy link
Member

@ms10398 ms10398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix alert posted above

@christianbender christianbender added the on hold Being discussed by the maintainers label Feb 18, 2019
@ms10398
Copy link
Member

ms10398 commented Mar 21, 2019

Reopen it when the changes are done

@ms10398 ms10398 closed this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Being discussed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants