Skip to content

added Backtracking/AllCombinationsOfSizeK #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

added Backtracking/AllCombinationsOfSizeK #748

merged 2 commits into from
Oct 6, 2021

Conversation

chiranjeev-thapliyal
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Added a new algorithm AllCombinationsOfSizeK in Backtracking
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 6, 2021
chiranjeev-thapliyal
chiranjeev-thapliyal commented Oct 6, 2021
View reviewed changes
Copy link
Contributor Author

@chiranjeev-thapliyal chiranjeev-thapliyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added test for AllCombinationsOfSizeK
  • used .mjs extension in tests folder

@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label Oct 6, 2021
@raklaptudirm raklaptudirm merged commit 7be5ce0 into TheAlgorithms:master Oct 6, 2021
lvlte added a commit to lvlte/Javascript that referenced this pull request Oct 9, 2021
@lvlte
Fix TheAlgorithms#748 : Revise algorithm implementation so that it ac…
4f4deac 
…tually returns the combinations. Fix test (was not running, .mjs not matching Jest pattern) and work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiranjeev-thapliyal @raklaptudirm