Skip to content

Add project-euler problem 12 #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2021
Merged

Add project-euler problem 12 #767

merged 6 commits into from
Oct 21, 2021

Conversation

aayushborkar14
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2021

This pull request introduces 1 alert when merging 8ea9cf5 into 5f601fa - view on LGTM.com

new alerts:

  • 1 for Inconsistent direction of for loop

@raklaptudirm
Copy link
Member

Please fix the raised alerts.

@aayushborkar14
Copy link
Contributor Author

How do I add an infinite loop with a base case without LGTM raising alert?

@aayushborkar14
Copy link
Contributor Author

I'm unable to understand whether the LGTM alert is fixed or not. Can you check?

raklaptudirm
raklaptudirm requested changes Oct 10, 2021
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these and the alerts should get fixed.

@raklaptudirm raklaptudirm added changes required This pull request needs changes feature Adds a new feature Reviewed algorithm Adds or improves an algorithm labels Oct 10, 2021
@aayushborkar14
Copy link
Contributor Author

aayushborkar14 commented Oct 11, 2021 •
edited
Loading

Alerts not fixed yet

@raklaptudirm
Copy link
Member

The alert is fixed.

@aayushborkar14
Copy link
Contributor Author

So will it get merged, or any more changes required?

@raklaptudirm raklaptudirm merged commit 278dc5c into TheAlgorithms:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aayushborkar14 @raklaptudirm