Optimized code

[utsav0]

Welcome to the JavaScript community

 know more

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new JavaScript files are placed inside an existing directory.
• All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
  Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[utsav0]

Both variables are already declared before the "if" statement. Do we still need to declare them inside again?

[raklaptudirm]

Remove the previous declarations.

[raklaptudirm]

Format your code with standard.js

[utsav0]

Nothing is changing even after formatting with standardjs.
It's only suggesting to declare maxNum with const instead of let

[raklaptudirm]

Then do that.

[raklaptudirm]

@utsav0 Run standard --fix to fix all the issues.

[utsav0]

I did it many times. It's still the same code so nothing to commit.

[raklaptudirm]

What command are you running?

[utsav0]

standard --fix

…

On Mon, 28 Mar, 2022, 11:41 PM Rak Laptudirm, ***@***.***> wrote: What command are you running? — Reply to this email directly, view it on GitHub <#951 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWV6TE2EPYAHL4XFHDG2IITVCHY4LANCNFSM5RXABLIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[raklaptudirm]

Are you doing it in the code directory?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[appgurueu]

LGTM. Could be even shorter as let lcm = Math.max(...) but is fine either way.

[raklaptudirm]

@utsav0 You need to style your code.

[merelymyself]

Minor formatting issue, please fix.

[appgurueu]

@raklaptudirm after your latest change, the PR contains effectively no content anymore as the Math.max change was merged in another PR already.

[utsav0]

I'm doing it in the root directory of the project.

…

On Tue, 29 Mar, 2022, 12:14 PM Rak Laptudirm, ***@***.***> wrote: Are you doing it in the code directory? — Reply to this email directly, view it on GitHub <#951 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWV6TE67WZC4AQNIY4CG463VCKRDNANCNFSM5RXABLIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>