Skip to content

Hash djb2 #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 16, 2020
Merged

Hash djb2 #2098

merged 7 commits into from
Jun 16, 2020

Conversation

bnMikheili
Copy link
Contributor

Following PR implements hash function djb2

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
@TravisBuddy
Copy link

Hey @bnMikheili,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e2b01c70-b00c-11ea-ae15-c70b0cf57a1c

@cclauss cclauss merged commit 62f7561 into TheAlgorithms:master Jun 16, 2020
@TravisBuddy
Copy link

Hey @bnMikheili,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 44ce4bf0-b00f-11ea-ae15-c70b0cf57a1c

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@bnMikheili @cclauss @stokhos
Hash djb2 (TheAlgorithms#2098)
d17019d 
* implement hash

* fix flake8 error

* Update hashes/djb2.py

* Update hashes/djb2.py

* Long lines

* def djb2(s: str) -> int:

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@swapnanildutta swapnanildutta swapnanildutta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnMikheili @TravisBuddy @cclauss @swapnanildutta