Implement prefix function, knuth-morris-pratt another usage #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nikalosa, TravisCI finished with status TravisBuddy Request Identifier: 021ced60-ac9b-11ea-8245-836d9da6cb4c |
cclauss
reviewed
Jun 14, 2020
strings/prefix_function.py
Outdated
| 2 | ||
| """ | ||
|
|
||
| prefix_result = prefix_function(input_str) |
There was a problem hiding this comment.
Why create a variable only to throw it away on the next line?
There was a problem hiding this comment.
I changed that, returning max value right away
There was a problem hiding this comment.
Any more requirements for this code?
cclauss
approved these changes
Jun 17, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…ithms#2099) * Implement prefix function, knuth-morris-pratt another usage * fixup! Format Python code with psf/black push * Fix style * updating DIRECTORY.md * Update prefix_function.py Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Prefix function implementation, another usage of knuth-morris-pratt algorithm
Checklist:
Fixes: #{$ISSUE_NO}.