Skip to content

Update scoring_functions.py #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Conversation

tanujdhiman
Copy link
Contributor

@tanujdhiman tanujdhiman commented Aug 8, 2020

We can find accuracy by manually if we are not going to use sklearn library.

We can find accuracy by manually if we are not going to use sklearn library.
@TravisBuddy
Copy link

Hey @tanujdhiman,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1a44c980-d978-11ea-b7d0-872145514bcc

@cclauss
Copy link
Member

cclauss commented Aug 8, 2020

@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Sep 7, 2020
@spamegg1
Copy link
Contributor

spamegg1 commented Sep 9, 2020

@tanujdhiman All you need to do is remove whitespaces from lines 143 and 145

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Sep 9, 2020
@tanujdhiman
Copy link
Contributor Author

tanujdhiman commented Sep 9, 2020

@spamegg1 I think it is a good practice of not dependent on some library like Sklearn. It's my suggestion. What are your views ?

@cclauss cclauss merged commit 25946e4 into TheAlgorithms:master Sep 9, 2020
@TravisBuddy
Copy link

Hey @tanujdhiman,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ade9f340-f2be-11ea-82b8-f1691ab9f797

Copy link
Contributor Author

@tanujdhiman tanujdhiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Update scoring_functions.py

We can find accuracy by manually if we are not going to use sklearn library.

* Update scoring_functions.py

* Update machine_learning/scoring_functions.py

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants