Skip to content

fixes #4529 #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fixes #4529 #4534

wants to merge 1 commit into from

Conversation

bumfuzzle33
Copy link
Contributor

@bumfuzzle33 bumfuzzle33 commented Jul 8, 2021

The mistake caused the code to output wrong hashes of strings greater than 64 bytes

Describe your change:

tabbed lines 121 - 127 once

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

The mistake caused the code to output wrong hashes of strings greater than 64 bytes
@ghost
Copy link

ghost commented Jul 8, 2021

Closing this pull request as invalid

@bumfuzzle33, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@ghost ghost added the invalid label Jul 8, 2021
@ghost ghost closed this Jul 8, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Jul 8, 2021
@bumfuzzle33 bumfuzzle33 deleted the patch-2 branch July 12, 2021 14:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant