Skip to content

Fix indentation in sha1.py #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix indentation in sha1.py #4535

wants to merge 1 commit into from

Conversation

bumfuzzle33
Copy link
Contributor

The mistake caused the code to output wrong hashes of strings greater than 64 bytes

Describe your change:

tabbed lines 121 - 127 once

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@bumfuzzle33
fixes #4529
645f942 
The mistake caused the code to output wrong hashes of strings greater than 64 bytes
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 8, 2021
@bumfuzzle33 bumfuzzle33 closed this Jul 8, 2021
@bumfuzzle33 bumfuzzle33 reopened this Jul 8, 2021
@poyea poyea linked an issue Jul 9, 2021 that may be closed by this pull request
Indentation mistake #4529
Closed
@ghost ghost added the tests are failing Do not merge until tests pass label Jul 9, 2021
@poyea poyea changed the title fixes #4529 Fix indentation in sha1.py Jul 9, 2021
poyea
poyea reviewed Jul 9, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing build. Also, it'd be good if there are tests to support this change. Guidelines are in our CONTRIBUTING.md. Thanks!!

@bumfuzzle33 bumfuzzle33 deleted the patch-2 branch July 12, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea left review comments

@yasiralamriki yasiralamriki yasiralamriki approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indentation mistake
3 participants
@bumfuzzle33 @poyea @yasiralamriki