Skip to content

bugfix: Add abs_max.py & abs_min.py empty list detection #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

bugfix: Add abs_max.py & abs_min.py empty list detection #4844

merged 2 commits into from
Oct 6, 2021

Conversation

taseikyo
Copy link
Contributor

@taseikyo taseikyo commented Oct 1, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@taseikyo taseikyo requested a review from Kush1101 as a code owner October 1, 2021 12:11
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 1, 2021
@taseikyo
Copy link
Contributor Author

taseikyo commented Oct 1, 2021

@poyea could you please review my pr? :P

@poyea
Copy link
Member

poyea commented Oct 4, 2021

These two files fail check-executables-have-shebangs check. Please try chmod -x these two files and commit them again

@poyea poyea self-assigned this Oct 4, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 6, 2021
@taseikyo
Copy link
Contributor Author

taseikyo commented Oct 6, 2021

These two files fail check-executables-have-shebangs check. Please try chmod -x these two files and commit them again

done

poyea
poyea approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 6, 2021
@poyea poyea merged commit a4d68d6 into TheAlgorithms:master Oct 6, 2021
@taseikyo taseikyo deleted the bugfix branch October 7, 2021 02:02
@poyea poyea mentioned this pull request Oct 16, 2021
Merged
15 tasks
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@taseikyo @shermanhui
bugfix: Add abs_max.py & abs_min.py empty list detection (TheAlgorith…
40aed40 
…ms#4844)

* bugfix: Add abs_max.py & abs_min.py empty list detection

* fix shebangs check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taseikyo @poyea