Simple audio filters #5230
Merged
Simple audio filters #5230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martmists <[email protected]>
Signed-off-by: Martmists <[email protected]>
Signed-off-by: Martmists <[email protected]>
ghost
added
awaiting reviews
ghost
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Signed-off-by: Martmists <[email protected]>
ghost
removed
the
require type hints
ghost
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Signed-off-by: Martmists <[email protected]>
|
Note: doctests may fail due to typing.Protocol requiring doctests, see also #5231. |
cclauss
reviewed
Oct 11, 2021
cclauss
requested changes
Oct 11, 2021
ghost
added
awaiting changes
Signed-off-by: Martmists <[email protected]>
ghost
added
awaiting reviews
Signed-off-by: Martmists <[email protected]>
Signed-off-by: Martmists <[email protected]>
cclauss
reviewed
Oct 15, 2021
cclauss
reviewed
Oct 15, 2021
Signed-off-by: Martmists <[email protected]>
Signed-off-by: Martmists <[email protected]>
|
Is there proof that list comprehensions are really slower?!? Perhaps a timeit benchmark? According to CONTRIBUTING.md, algorithmic functions should return values and should not print or plot. Is there a way to separate the calculations into separate functions from plotting? In this way, we can put doctests on the algorithmic functions. |
cclauss
reviewed
Oct 15, 2021
cclauss
reviewed
Oct 15, 2021
Signed-off-by: Martmists <[email protected]>
Signed-off-by: Martmists <[email protected]>
|
@cclauss any updates on this? |
cclauss
reviewed
Oct 23, 2021
cclauss
reviewed
Oct 23, 2021
Co-authored-by: Christian Clauss <[email protected]>
Signed-off-by: Martmists <[email protected]>
ghost
reviewed
Oct 23, 2021
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Signed-off-by: Martmists <[email protected]>
ghost
removed
the
require type hints
cclauss
approved these changes
Oct 23, 2021
cclauss
approved these changes
Oct 23, 2021
cclauss
approved these changes
Oct 23, 2021
|
@Martmists-GH Thanks for your super cool contribution!!! I am OK with this version. If it is good for you, please let me know and I will merge it. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add N-order IIR filter and Butterworth coefficients calculations
Checklist:
Fixes: #{$ISSUE_NO}.