Skip to content

Update: graph_matrix #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update: graph_matrix #5318

wants to merge 2 commits into from

Conversation

priyaa-rawat
Copy link

@priyaa-rawat priyaa-rawat commented Oct 15, 2021

Describe your change:

Did some changes by implementing if conditions to prevent "IndexOverflow" error and added a function to remove an edge.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • [x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming #conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
    Hacktoberfest 2021 - Implement algorithms or data structures, fix existing ones and more! #4996 @cclauss @poyea

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 15, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 15, 2021
@priyaa-rawat priyaa-rawat requested a review from cclauss October 15, 2021 13:30
@priyaa-rawat
Copy link
Author

priyaa-rawat commented Oct 15, 2021

@cclauss is printing error messages through exceptions allowed?

        try:
            self.graph[u - 1][v - 1] = 1
            self.graph[v - 1][u - 1] = 1
        except IndexError as e:
            print(e)
            raise

@cclauss
Copy link
Member

cclauss commented Oct 15, 2021

As long as your raise after you print() like I added above.

Or better yet, raise IndexError("This is my even better error message.")

@priyaa-rawat priyaa-rawat mentioned this pull request Oct 15, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants