Skip to content

Update pop function #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 23, 2021
Merged

Update pop function #5544

merged 8 commits into from
Oct 23, 2021

Conversation

limbad-YK
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@limbad-YK
Updated Pop function
7402a02 
Added underflow condition
@limbad-YK
Update Pop Function
00e0a1b 
Added condition to check underflow of stack
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 23, 2021
cclauss
cclauss reviewed Oct 23, 2021
View reviewed changes
data_structures/stacks/stack.py Outdated
@@ -32,6 +34,8 @@ def push(self, data):

def pop(self):
"""Pop an element off of the top of the stack."""
if not self.stack: # Condition to check Underflow of stack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not self.stack: # Condition to check Underflow of stack
if not self.stack: # Condition to check Underflow of stack

cclauss
cclauss reviewed Oct 23, 2021
View reviewed changes
data_structures/stacks/stack.py Outdated
@@ -64,6 +68,7 @@ def test_stack() -> None:
assert stack.is_full() is False
assert str(stack) == "[]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert str(stack) == "[]"
assert stack == []

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 23, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 23, 2021
cclauss
cclauss approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2021
@cclauss cclauss merged commit 80a885c into TheAlgorithms:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@spartan289 spartan289 spartan289 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limbad-YK @cclauss @spartan289