Skip to content

[mypy] Fix type annotations for binary tree traversals in data structures #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 28, 2021
Merged

[mypy] Fix type annotations for binary tree traversals in data structures #5556

merged 11 commits into from
Oct 28, 2021

Conversation

dylanbuchi
Copy link
Contributor

@dylanbuchi dylanbuchi commented Oct 23, 2021 •
edited
Loading

Describe your change:

Fix errors for mypy inside binary tree traversals, add missing type annotations, add a type alias NodeType and refactor level_order_1 function.

Related Issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 23, 2021
@ghost ghost mentioned this pull request Oct 24, 2021
Closed
14 tasks
@dylanbuchi
Change variable name and update level_order_1 to use a deque
544b3fc 
Using a deque instead of a list here, because since we are removing from the beginning of the list, the deque will be more efficient.
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 26, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 26, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 26, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 26, 2021
@dylanbuchi dylanbuchi requested review from cclauss and poyea October 26, 2021 17:43
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 26, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 27, 2021
poyea
poyea approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2021
@poyea poyea merged commit bf6db32 into TheAlgorithms:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanbuchi @cclauss @poyea