Skip to content

add implementation of Nagel and Schrekenberg algo #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 26, 2021
Merged

add implementation of Nagel and Schrekenberg algo #5584

merged 14 commits into from
Oct 26, 2021

Conversation

Leoriem-code
Copy link
Contributor

@Leoriem-code Leoriem-code commented Oct 24, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 24, 2021
cclauss
cclauss reviewed Oct 24, 2021
View reviewed changes
cclauss
cclauss reviewed Oct 24, 2021
View reviewed changes
cclauss
cclauss reviewed Oct 24, 2021
View reviewed changes
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 24, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 25, 2021
@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2021
cclauss
cclauss approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removed unused globals.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@cclauss cclauss merged commit 8e857e8 into TheAlgorithms:master Oct 26, 2021
@Leoriem-code Leoriem-code deleted the cellular_automata branch October 26, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leoriem-code @cclauss