Skip to content

[mypy-fix] Type fixes for graham_scan #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

spazm
Copy link
Contributor

@spazm spazm commented Oct 25, 2021

Describe your change:

Fixed type annoations on other/graham_scan

Before

% git checkout master
% mypy --ignore-missing-imports  graham_scan.py
graham_scan.py:17: error: "list" expects 1 type argument, but 2 given
graham_scan.py:60: error: "list" expects 1 type argument, but 2 given
graham_scan.py:88: error: Argument 2 to "insert" of "list" has incompatible type "Tuple[int, int]"; expected "List[Any]"
graham_scan.py:97: error: Missing return statement
graham_scan.py:98: error: "list" expects 1 type argument, but 2 given
graham_scan.py:140: error: Need type annotation for "stack"
Found 6 errors in 1 file (checked 1 source file)

After

% git checkout mypy-fix-other-graham_scan
% mypy --ignore-missing-imports  graham_scan.py
Success: no issues found in 1 source file

% mypy --ignore-missing-imports  --strict graham_scan.py
Success: no issues found in 1 source file
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 25, 2021
@spazm spazm changed the title [Mypy-fix] Type fixes for graham_scan [mypy-fix] Type fixes for graham_scan Oct 25, 2021
@spazm spazm force-pushed the mypy-fix-other-graham_scan branch from 9b2d99c to ab51cc6 Compare October 25, 2021 09:00
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@cclauss cclauss merged commit 2606f1b into TheAlgorithms:master Oct 26, 2021
@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants