Skip to content

Improve Project Euler problem 014 solution 1 #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Improve Project Euler problem 014 solution 1 - the top 2 slowest solution on Travis CI logs (under slowest 10 durations: 13.91s call scripts/validate_solutions.py::test_project_euler[problem_014/sol1.py]):

  • Improve solution (locally 10+ times - from 15+ seconds to ~1.5 seconds)

  • Uncomment code that has been commented due to slow execution affecting Travis (now it should be quite fast execution and not affect Travis)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 1, 2021
@cclauss
Copy link
Member

cclauss commented Nov 1, 2021

We decommissioned Travis CI a year ago.
https://app.travis-ci.com/github/TheAlgorithms/Python/builds

Our current tests are run at https://github.com/TheAlgorithms/Python/actions

@MaximSmolskiy
Copy link
Member Author

MaximSmolskiy commented Nov 2, 2021

We decommissioned Travis CI a year ago. https://app.travis-ci.com/github/TheAlgorithms/Python/builds

Our current tests are run at https://github.com/TheAlgorithms/Python/actions

But then should it be replaced everywhere (Travis CI with GitHub Actions)? Because now Travis CI is mentioned in many places (for example, in CONTRIBUTING.md)

@cclauss
Copy link
Member

cclauss commented Nov 2, 2021

Repo maintenance is a team sport so please create a pull request to remove all instances of Travis CI and we will gladly review it. https://github.com/TheAlgorithms/Python/search?q=Travis

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 4, 2021
@cclauss cclauss merged commit e835e96 into TheAlgorithms:master Nov 4, 2021
@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-014-solution-1 branch November 4, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants