Skip to content

Add sin function to /maths #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2022
Merged

Add sin function to /maths #5949

merged 5 commits into from
May 16, 2022

Conversation

zefr0x
Copy link
Contributor

@zefr0x zefr0x commented Jan 25, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@zefr0x zefr0x requested a review from Kush1101 as a code owner January 25, 2022 21:44
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jan 25, 2022
@zefr0x zefr0x changed the title Add sin function to /maths. Add sin function to /maths Jan 27, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Feb 24, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 16, 2022
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 12, 2022
@stale stale bot removed the stale Used to mark an issue or pull request stale. label May 12, 2022
>>> sin(270.0)
-1.0
>>> sin(0.68)
0.0118679603
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this seems to be incorrect? sin(0.68) = 0.628793

Copy link
Contributor Author

@zefr0x zefr0x May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math.sin function in python accepts an angle measured in radians, but my sin function accepts an angle measured in degrees.

If you tested that with math.sin function, do like this to get the right result:

>>> import math
>>> math.sin(math.radians(0.68))
0.011867960298537237

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, sin(9999.0) = -0.9876883405951389?

@ghost ghost added the awaiting changes A maintainer has requested changes to this PR label May 12, 2022
@zefr0x zefr0x requested a review from poyea May 14, 2022 17:36
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label May 16, 2022
@poyea poyea merged commit 80f1da2 into TheAlgorithms:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants