Skip to content

Increased Readability Of Variables #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2022
Merged

Increased Readability Of Variables #6400

merged 5 commits into from
Oct 30, 2022

Conversation

ok-open-sc
Copy link
Contributor

Describe your change:

Increased Readability Of Variables

Checklist:

  • [ Yes] I have read CONTRIBUTING.md.
  • [ Yes] This pull request is all my own work -- I have not plagiarized.
  • [ Yes] I know that pull requests will not be merged if they fail the automated tests.
  • [ Yes] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ Yes] All new Python files are placed inside an existing directory.
  • [ Yes] All filenames are in all lowercase characters with no spaces or dashes.
  • [ Yes] All functions and variable names follow Python naming conventions.
  • [ Yes] All function parameters and return values are annotated with Python type hints.
  • [ Yes] All functions have doctests that pass the automated testing.
  • [ Yes] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ Yes] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@xijiehuayuan5
Copy link

Nice!

CaedenPH
CaedenPH reviewed Sep 30, 2022
View reviewed changes
strings/anagrams.py Outdated
>>> anagram('test')
['sett', 'stet', 'test']
>>> anagram('this is a test')
[]
>>> anagram('final')
['final']
"""
return word_bysig[signature(my_word)]
return word_by_sig[signature(my_word)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return word_by_sig[signature(my_word)]
return word_by_signature[signature(my_word)]

What is your opinion on renaming word_by_sig to word_by_signature?

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 30, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 30, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@cclauss cclauss merged commit 0c5f1c0 into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ok-open-sc @xijiehuayuan5 @cclauss @CaedenPH