Skip to content

Create superdense_coding.py #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2022
Merged

Create superdense_coding.py #7349

merged 2 commits into from
Oct 23, 2022

Conversation

KevinJoven11
Copy link
Contributor

Describe your change:

Add quantum superdense coding algorithm. The principal idea is to send two classical bits in to one quantum bit (qubit.)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 17, 2022
@KevinJoven11
Copy link
Contributor Author

Dear @cclauss,
This is the final contribution required for the #Hacktoberfest.
Thanks for your comments and help. I really appreciate your time.
Let me know if everything works well.
Best,

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 17, 2022
poyea
poyea approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea self-assigned this Oct 19, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 19, 2022
CaedenPH
CaedenPH requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the qasm_simulator deprecation (#7308)

quantum/superdense_coding.py
# measure the circuit
quantum_circuit.measure(qr, cr)

backend = Aer.get_backend("qasm_simulator")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qasm_simulator has been deprecated (#7308)

quantum/superdense_coding.py
bit_2: bit 2 of classical information to send.
Returns:
qiskit.result.counts.Counts: counts of send state.
>>> superdense_coding(0,0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> superdense_coding(0,0)
>>> superdense_coding(0,0)

@prateekiiest prateekiiest merged commit a536279 into TheAlgorithms:master Oct 23, 2022
@CaedenPH
Copy link
Contributor

@prateekiiest I had made a pretty important comment that qasm_simulator is deprecated, so this algorithm will raise warnings and someone will need to fix this

CaedenPH added a commit to CaedenPH/Python that referenced this pull request Oct 23, 2022
@CaedenPH
Revert "Create superdense_coding.py (TheAlgorithms#7349)"
fbd9f40 
This reverts commit a536279.
prateekiiest added a commit that referenced this pull request Oct 23, 2022
@prateekiiest
Revert "Create superdense_coding.py (#7349)"
a9b999c 
This reverts commit a536279.
@prateekiiest prateekiiest mentioned this pull request Oct 23, 2022
Closed
@prateekiiest
Copy link
Member

@CaedenPH made a revert PR. sorry for missing that

@prateekiiest
Copy link
Member

Closing as per PR comments. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH requested changes

@prateekiiest prateekiiest prateekiiest approved these changes

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KevinJoven11 @CaedenPH @prateekiiest @poyea @cclauss