Skip to content

Update password_generator.py #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2022
Merged

Update password_generator.py #7745

merged 2 commits into from
Oct 29, 2022

Conversation

pronoym99
Copy link
Contributor

@pronoym99 pronoym99 commented Oct 27, 2022 •
edited
Loading

  1. Use secrets module instead of random for passwords as it gives a secure source of randomness
  2. Add type annotations for functions which are in use
  3. Avoid unnecessary usage of iterator variables wherever not required
  4. Replace ctbi (variable for the characters to be included) with a more meaningful and short name
  5. Use integer division instead of obtaining the integer part of a division resulting in a floating point

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pronoym99
Update password_generator.py
fe741fb 
1. Use secrets module instead of random for passwords as it gives a secure source of randomness
2. Add type annotations for functions
3. Replace ctbi (variable for the characters to be included) with a more meaningful and short name
4. Use integer division instead of obtaining the integer part of a division computing a floating point
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 27, 2022
@pronoym99
Copy link
Contributor Author

I suggest you add a hacktoberfest label to this PR.

This was referenced Oct 27, 2022
Closed
Closed
Closed
cclauss
cclauss approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 29, 2022
@cclauss cclauss merged commit 18ffc4d into TheAlgorithms:master Oct 29, 2022
@pronoym99 pronoym99 deleted the patch-2 branch October 29, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pronoym99 @cclauss