Skip to content

Update check_strong_password.py #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update check_strong_password.py #7747

wants to merge 1 commit into from

Conversation

pronoym99
Copy link
Contributor

@pronoym99 pronoym99 commented Oct 27, 2022 •
edited
Loading

  1. Change the functional concept that a strong password checker must return a boolean indicating whether the password is strong or not AND not a response string, the choice of which can be subjective.
  2. Add another alternative checker which has a theoretical time complexity better than the original one.
  3. Rectify the length checking to adhere to the minimum length as opposed to a hardcoded value.
  4. Optimise to make more Pythonic expressions and returns.
  5. Change the adjoining documentation as per 1.
  6. Add comments wherever necessary.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pronoym99
Update check_strong_password.py
5469c25 
1. Change the functional concept that a strong password checker must return a boolean indicating whether the password is strong or not AND not a response string, the choice of which can be subjective.
2. Add another alternative checker which has a theoretical time complexity better than the original one.
3. Rectify the length checking to adhere to the minimum length as opposed to a hardcoded value.
4. Optimise to make more Pythonic expressions and returns.
5. Add comments wherever necessary.
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 27, 2022
@pronoym99
Copy link
Contributor Author

I would suggest you add a hacktoberfest label to this PR.

This was referenced Oct 27, 2022
Closed
Closed
Closed
@cclauss
Copy link
Member

cclauss commented Oct 29, 2022

Duplicate: https://github.com/TheAlgorithms/Python/search?q=password

Please do not open any new pull requests until November 1st,. 2022

@cclauss cclauss closed this Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pronoym99 @cclauss