new and better approach for genetic algorithm in python #9624
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
genetic_algorithm/approach2.py
Outdated
| ''' | ||
| Class representing individual in population | ||
| ''' | ||
| def __init__(self, chromosome): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: chromosome
genetic_algorithm/approach2.py
Outdated
| self.fitness = self.cal_fitness() | ||
|
|
||
| @classmethod | ||
| def mutated_genes(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/approach2.py, please provide doctest for the function mutated_genes
Please provide return type hint for the function: mutated_genes. If the function does not return a value, please provide the type hint as: def function() -> None:
genetic_algorithm/approach2.py
Outdated
| return gene | ||
|
|
||
| @classmethod | ||
| def create_gnome(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/approach2.py, please provide doctest for the function create_gnome
Please provide return type hint for the function: create_gnome. If the function does not return a value, please provide the type hint as: def function() -> None:
genetic_algorithm/approach2.py
Outdated
| gnome_len = len(TARGET) | ||
| return [self.mutated_genes() for _ in range(gnome_len)] | ||
|
|
||
| def mate(self, par2): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/approach2.py, please provide doctest for the function mate
Please provide return type hint for the function: mate. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: par2
genetic_algorithm/approach2.py
Outdated
| # generated chromosome for offspring | ||
| return Individual(child_chromosome) | ||
|
|
||
| def cal_fitness(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/approach2.py, please provide doctest for the function cal_fitness
Please provide return type hint for the function: cal_fitness. If the function does not return a value, please provide the type hint as: def function() -> None:
| return fitness | ||
|
|
||
| # Driver code | ||
| def main(): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/approach2.py, please provide doctest for the function main
Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:
genetic_algorithm/approach2.py
Outdated
| while not found: | ||
|
|
||
| # sort the population in increasing order of fitness score | ||
| population = sorted(population, key = lambda x:x.fitness) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
genetic_algorithm/approach2.py
Outdated
|
|
||
| population = new_generation | ||
|
|
||
| print("Generation: {}\tString: {}\tFitness: {}".\ |
There was a problem hiding this comment.
As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.
genetic_algorithm/approach2.py
Outdated
| generation += 1 | ||
|
|
||
|
|
||
| print("Generation: {}\tString: {}\tFitness: {}".\ |
There was a problem hiding this comment.
As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.
for more information, see https://pre-commit.ci
|
Plagiarized from this GeeksforGeeks article.
|
tianyizheng02
added
invalid
Plagiarism!!
Describe your change:
I have added a new approach for genetic algorithm.
Please view it and accept my pull request.
Checklist: