close socket connection issue #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2011 17:30
|
Please take a look at these 2 commits. These are critical fixes. |
TooTallNate
added a commit
that referenced
this pull request
Jul 3, 2011
WebSocketClient close socket connection issue
maakolk
pushed a commit
to maakolk/Java-WebSocket
that referenced
this pull request
Mar 5, 2017
WebSocketClient close socket connection issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close socket connection issue fix (connection do not close when manually calling close()).
Hey, I found a bug and I prepared a small fix. As explained, when you call close() it does not immediately close the connection and leave it opened for awhile. The problem was that to loop stopped after the connection was blocked.
Please check and merge.