Skip to content

Conversation

@LiverpoolOwen
Copy link
Contributor

@LiverpoolOwen LiverpoolOwen commented Apr 4, 2017

Hello mate,

I didn't mean to close the other pull request I was deleting some of my remote branches after merging back to master.

Anyway, let me know what you think of the changes.

Thanks.

Closes #122

@MarkPieszak
Copy link
Member

This looks excellent! Nicely done!
Cheers 🍻

@MarkPieszak MarkPieszak merged commit 928c28b into TrilonIO:master Apr 4, 2017
@MarkPieszak
Copy link
Member

We can split it up into a Service in ./shared/users/user.service.ts later, otherwise looks great

@LiverpoolOwen
Copy link
Contributor Author

Good idea mate, I will sort that out later. I will make the table a bit prettier as well I think amd throw some extra angular validation on there as well maybe.

@LiverpoolOwen
Copy link
Contributor Author

What's the highest priority work for this do you think atm?

@MarkPieszak
Copy link
Member

MarkPieszak commented Apr 4, 2017

I have AoT "basically" working, but I need to figure out one issue it's throwing that seems to be something overall going wrong with @ngtools/webpack, but I'm investigating now. Trying to get this settled so I can check it in, and then can start getting all the other pieces back together!

I wanted to get ng2-bootstrap with bootstrap4 & SASS (for themeing) in there, but feel like that might be a next step for after AoT is finished.

Maybe some type of basic Authentication would be nice? ala #59?

Also not sure if #149 is fixed, but guessing so.

@LiverpoolOwen
Copy link
Contributor Author

Cool I will look into these and try get something done

@MarkPieszak
Copy link
Member

The fonts for glyphicons weren't coming through bootstrap-sass, you can see the 404s in the browser, gotta figure that one out too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to add a CRUD app in app showcase

2 participants