Skip to content

Created User service #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2017
Merged

Created User service #185

merged 6 commits into from
Apr 16, 2017

Conversation

@LiverpoolOwen
Copy link
Contributor

No description provided.

MarkPieszak
MarkPieszak approved these changes Apr 16, 2017
View reviewed changes
Copy link
Member

@MarkPieszak MarkPieszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Definitely want people to separate things 👍

@MarkPieszak MarkPieszak merged commit 0b7aa25 into TrilonIO:master Apr 16, 2017
@LiverpoolOwen
Copy link
Contributor Author

I see the documents for the web API in the root folder, they would now need updating after the web API changes I made earlier or we could remove them? It is pretty basic web API stuff really so I am not sure we need this at all TBH but if we are going to have API documentation we may be better implementing Swagger or something similar? so the documentation is built into the code?

I noticed there is no server side unit testing anymore, is this going to be added back in?

@MarkPieszak
Copy link
Member

MarkPieszak commented Apr 16, 2017 •
edited
Loading

Yeah we need to add that back in, and you're right Swagger would be excellent!
We can just remove hose for now, yeah they're older pictures.

@LiverpoolOwen
Copy link
Contributor Author

I just added Swagger locally and it was easy to set up but the MapSpaFallbackRoute causes a redirect. Any ideas on how we can exclude this from the fallback?

@LiverpoolOwen
Copy link
Contributor Author

image

@AKlaus AKlaus mentioned this pull request Jun 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkPieszak MarkPieszak MarkPieszak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LiverpoolOwen @MarkPieszak