Skip to content

Conversation

@LiverpoolOwen
Copy link
Contributor

I have just realised how to limit the pull requests to the specific commits. Funnily enough via https://stackoverflow.com/questions/5256021/send-a-pull-request-on-github-for-only-latest-commit
which you edited ha. :)

@MarkPieszak
Copy link
Member

Haha small world right 😅
Want me to merge it in, did you ever figure out the SpaRoute issue?

@LiverpoolOwen
Copy link
Contributor Author

Indeed it is!

Yeah I figured it out. It currently uses the SPA fall back route when there is not controller but I added a condition so that it will it will only fall back if it's not swagger. It feels a bit hacky though. What do you think? Change is in the start-up file.

@MarkPieszak
Copy link
Member

I saw that, seems good to me though! Can always change it later if we find a different way of doing it.
This is great stuff though man, thanks for the help 👍👍

@MarkPieszak MarkPieszak merged commit 3ce881c into TrilonIO:master Apr 17, 2017
@LiverpoolOwen
Copy link
Contributor Author

No worries mate. This is an awesome template you have made. I will hopefully be making use of it a lot in future.

@LiverpoolOwen
Copy link
Contributor Author

I seem to have introduced a bug, it can't find the asset file now when in dev mode. Maybe we should back this out?

@LiverpoolOwen
Copy link
Contributor Author

I have fixed the bug so will send another pull request

@MarkPieszak
Copy link
Member

Excellent ! 🍾
Yeah hoping to just keep making it better and easier to use as time goes on. I need to upgrade / fix the webpack stuff next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants