Skip to content

Conversation

@JustMaier
Copy link
Contributor

Just a little quality of life thing.

By keeping the dist folder out of the project, the navigate to functionality is faster and it keeps VS from thrashing on webpack rebuilds.

@MarkPieszak
Copy link
Member

Love it, thank you Justin! 👍

@MarkPieszak MarkPieszak merged commit bc14e00 into TrilonIO:master Apr 21, 2017
@M-R-Bishop
Copy link
Contributor

FYI - now when you clean the solution in Visual Studio 2017 the 'dist' folder is removed and doesn't regenerate until manually running 'npm run build:dev'. For now I've added a 'postinstall": "npm run build:dev' similar to what's described here: #166

@JustMaier
Copy link
Contributor Author

@M-R-Bishop I noticed the same issue when I ran the project for the first time. I think it's because currently WebPack just takes about 50s to build the packs necessary for the project to operate correctly. When you run the project it starts packing, but it doesn't finish until well after the server pack was needed.

It'd probably be good to find a way to make the server wait for webpack to finish if the files are missing. It'd also probably be good to take measure to reduce the webpack build time.

@MarkPieszak
Copy link
Member

MarkPieszak commented Apr 24, 2017

Yeah making especially webpack rebuilds is definitely important in the next steps of the repo. I'm moving this week so unfortunately swamped, it will tough to find time to finish those things right now :(

But you're right Justin, the server starts trying to load everything well before it's done sometimes and little errors can come up, I usually just hit F5 after a little bit and they all go away and it loads properly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants