Updated nosniff header to apply to non-204 responses only #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/tryghost/issue/ONC-179 - some self-hosters reported seing a prompt to download "auth-frame" when visiting a post with comments enabled on iOS - recently, we've worked on an optimisation for comments UI to return a empty 204 for /ghost/auth-frame/ when no staff admin is authenticated (more context TryGhost/Ghost#19840) - setting X-Content-Type-Options to nosniff helps to prevent browsers from interpreting files as a different MIME type than what is specified in the Content-Type header - however, when returning an empty 204 response (No Content, therefore no Content-Type to check), iOS safari interpret this header as a file to download from the url - with this change, we add the nosniff header only to non-204 responses
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ONC-179
/ghost/auth-frame/when no staff admin is authenticated (more context: 🎨 Reduced requests and 403 responses for comments auth check Ghost#19840)X-Content-Type-Optionstonosniffhelps to prevent browsers from interpreting files as a different MIME type than what is specified in theContent-TypeheaderNo Content, therefore noContent-Typeto check), iOS safari interprets the header as a file to download for some reasonnosniffheader to only non-empty responses (i.e. not HTTP 204)