Skip to content

Add support for Ubuntu 24.04 #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acburdine merged 3 commits into from
Jul 21, 2025
Merged

Add support for Ubuntu 24.04 #1954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d10979
Add support for Ubuntu 24.04
chorrell Apr 25, 2025
bec259b
Merge branch 'main' into ubuntu-24
acburdine Jul 17, 2025
8cce860
fix tests
acburdine Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: true
matrix:
os: [ubuntu-22.04]
os: [ubuntu-22.04, ubuntu-24.04]
password: [root]
node: [20.x]
steps:
Expand Down
4 changes: 2 additions & 2 deletions lib/commands/doctor/checks/system-stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const {SystemError} = require('../../../errors');

const taskTitle = 'Checking system compatibility';
const nginxProgramName = process.env.NGINX_PROGRAM_NAME || 'nginx';
const versionRegex = /^(?:16|18|20|22)/;
const versionRegex = /^(?:16|18|20|22|24)/;

async function hasService(name) {
try {
Expand All @@ -23,7 +23,7 @@ async function checkSystem(ctx) {

const {distro, release} = await sysinfo.osInfo();
if (distro !== 'Ubuntu' || !versionRegex.test(release)) {
throw new Error('Linux version is not Ubuntu 16, 18, 20, or 22');
throw new Error('Linux version is not Ubuntu 16, 18, 20, 22, or 24');
}

const missing = [];
Expand Down
6 changes: 3 additions & 3 deletions test/unit/commands/doctor/checks/system-stack-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe('Unit: Doctor Checks > systemStack', function () {
await systemStack.task(ctx);
} catch (error) {
expect(error).to.be.an.instanceof(SystemError);
expect(error.message).to.equal('System stack checks failed with message: \'Linux version is not Ubuntu 16, 18, 20, or 22\'');
expect(error.message).to.equal('System stack checks failed with message: \'Linux version is not Ubuntu 16, 18, 20, 22, or 24\'');
expect(osInfo.calledOnce).to.be.true;
expect(logStub.calledOnce).to.be.true;
expect(logStub.args[0][0]).to.match(/failed with message/);
Expand All @@ -100,7 +100,7 @@ describe('Unit: Doctor Checks > systemStack', function () {
expect(false, 'error should have been thrown').to.be.true;
});

it('rejects if os release is not Ubuntu 16, 18, or 20', async function () {
it('rejects if os release is not Ubuntu 16, 18, 20, 22, or 24', async function () {
const osInfo = sinon.stub(sysinfo, 'osInfo').resolves({distro: 'Ubuntu', release: '14.04.1 LTS'});
const logStub = sinon.stub();
const confirmStub = sinon.stub().resolves(false);
Expand All @@ -114,7 +114,7 @@ describe('Unit: Doctor Checks > systemStack', function () {
await systemStack.task(ctx);
} catch (error) {
expect(error).to.be.an.instanceof(SystemError);
expect(error.message).to.equal('System stack checks failed with message: \'Linux version is not Ubuntu 16, 18, 20, or 22\'');
expect(error.message).to.equal('System stack checks failed with message: \'Linux version is not Ubuntu 16, 18, 20, 22, or 24\'');
expect(osInfo.calledOnce).to.be.true;
expect(logStub.calledOnce).to.be.true;
expect(logStub.args[0][0]).to.match(/failed with message/);
Expand Down
Loading