Skip to content

Conversation

@rmgpinto
Copy link
Contributor

ref no-issue

  • Changed nginx templates to add activitypub paths for Ghost.

ref no-issue

- Changed nginx templates to add activitypub paths for Ghost.
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make enabling this opt-in with a flag (or maybe opt-out/on by default?)

@ErisDS
Copy link
Member

ErisDS commented Jul 21, 2025

I don't think there's a need?

The feature itself in Ghost is on-by default and having to enable it here first would add an unnecessary confusing barrier to entry.

If the feature is turned off, this rule won't get used, but having it won't really do anything.

If anyone really doesn't want it, they can delete it, which is fairly easy. I am not sure we have a good pattern for opting out in Ghost-CLI that is easier to understand than "go delete the block"?

@acburdine
Copy link
Member

that's fair 👍🏻

@acburdine acburdine merged commit f8cf5ca into main Jul 21, 2025
6 checks passed
@acburdine acburdine deleted the activitypub branch July 21, 2025 15:18
@jloh
Copy link
Member

jloh commented Jul 22, 2025

Thanks Austin!

@vikaspotluri123
Copy link
Member

Does nginx validate the hostnames for proxy_pass directives on startup? This forum topic reports an issue with ap.ghost.org after restarting their server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants