-
Notifications
You must be signed in to change notification settings - Fork 122
Integrate MDV6 firmware into Bazel #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itsarune
wants to merge
40
commits into
UBC-Thunderbots:master
Choose a base branch
from
itsarune:mdv6_firmware
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had some free time and cleaned up the mdv6 firmware integration into Bazel that I had.
Commands introduced
bazel build //firmware/motor:mdv6_firmware_main --platforms=//toolchains/cc:motor_boardworks and compilesbazel run //firmware/motor:mdv6_firmware_flash --platforms=//toolchains/cc:motor_boardworksTesting Done
Resolved Issues
Length Justification and Key Files to Review
Firmware
firmware/motor/is auto-generatedfirmware/motor/main.c,firmware/motor/crc.handfirmware/motor/crc.cThese files are copied from the MDV6 Firmware repo from August. They should comply with our style guidelines but they don't. I would rather have this handled in the future.Toolchains
toolchains/cc/cc_toolchains_config.bzlenvironment_setup/util.shenvironment_setup/software.shBazel 8 jank
bazel-embeddedprovides us with OpenOCD, which is the protocol that's used under-the-hood with STLINKsrc/defs.bzlsrc/MODULE.bazelReview Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue