This repository was archived by the owner on Jun 9, 2021. It is now read-only.
submission for final class project #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default url
codedragon
approved these changes
Mar 25, 2018
| response = run_screens(history) | ||
| message = "Here are your results for {}".format(symbol) | ||
| else: | ||
| message = "Invalid stock symbol '{}'".format(symbol) |
There was a problem hiding this comment.
There is a lot of code in this try block. Think about where you expect to get the ConnectionError, and try to limit the block in the try block to just that. Especially try to avoid conditionals in a try block.
|
|
||
| except ValueError as ve: | ||
| # If empty | ||
| return None |
There was a problem hiding this comment.
You should at least log the exceptions you are catching. And are you sure that you don't want the user to know about them at all?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the test results. Needed to use the built in test framework for Django to run my tests.
(venv) 15:18:24matt@luna:stockscreener$django-admin test exchange
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
..................................
Ran 34 tests in 0.154s
OK
Destroying test database for alias 'default'...