Sessions 7, 8, 9 Homework #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
You need to be consistent here. In one case you are returning a new object, and in the other you are returning the original object changed. You should almost certainly be returning a new object. If you want a function that returns the same object changed, you would use the augmented assignment (iadd, for example). You are correct that the reflected operator (rmul, below) would return the same thing as the normal operator (here and in most cases), and is often just a call to its non-reflected equivalent.
|
Made some comments on homework. Will send an email about project, since we have an updated version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homework for the last three sessions (7,8,9)