Skip to content

Conversation

@hosungs
Copy link
Contributor

@hosungs hosungs commented Oct 19, 2018

Tried to fix some typos in Lesson 4 pages as I was rereading them.

@PythonCHB
Copy link
Contributor

Thanks! I think there are some RST formatting issues still, but I'll check that out after merging.

Are you set up to to build the docs to see how they render? that would be helpful. And if you like, I can give you permissions to re-render the published version as well. I think it's good to have a PR for substantive changes, but for typos, might as well just publish them.

@PythonCHB PythonCHB merged commit a70033d into UWPCE-PythonCert:master Oct 20, 2018
@PythonCHB
Copy link
Contributor

OK -- I've fixed some RST, and updated the pages a bit.

(also added an optional Unicode page...)

@hosungs hosungs deleted the hs-lesson4 branch October 20, 2018 19:11
@hosungs
Copy link
Contributor Author

hosungs commented Oct 20, 2018

@PythonCHB -- Yes, I can run make.bat on my git bash cmdline to build HTMLs. I just get lazy with that step... Sorry about that. Sure, I'd be happy to just commit any typo fixes directly, without PRs. Thanks!

@PythonCHB
Copy link
Contributor

OK -- I've invited you to the team -- welcome aboard!

-CHB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants