Skip to content

Add visual indicator when a pure function is removed during optimization #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xusheng6 opened this issue Apr 23, 2025 · 2 comments
Open

Add visual indicator when a pure function is removed during optimization #6710

xusheng6 opened this issue Apr 23, 2025 · 2 comments
Labels
Component: Core Issue needs changes to the core Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround

Comments

@xusheng6
Copy link
Member

Right now we just remove pure functions from the decompilation entirely, and this could lead to various issues. I believe a better approach is to handle this in a similar way to our handling of eliminated writes, i.e., we display it in a different color, do not remove it entirely, and the user has the chance to confirm or deny the removal of the call
@xusheng6
Copy link
Member Author

Binary silly ocean glows quickly, address 0x1000c8a5

@xusheng6 xusheng6 added Component: Core Issue needs changes to the core Impact: Low Issue is a papercut or has a good, supported workaround Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround and removed Impact: Low Issue is a papercut or has a good, supported workaround labels Apr 23, 2025
@emesare
Copy link
Member

emesare commented Apr 23, 2025

Duplicate of #5557?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core Issue needs changes to the core Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emesare @xusheng6